Skip to content

[embind] Only initialize pthread member in multi-threaded builds. NFC #26508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Mar 20, 2026
Merged

[embind] Only initialize pthread member in multi-threaded builds. NFC #26508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions system/include/emscripten/val.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,11 @@ class EMBIND_VISIBILITY_DEFAULT val {

private:
// takes ownership, assumes handle already incref'd and lives on the same thread
explicit val(EM_VAL handle)
: handle(handle), thread(pthread_self())
{}
explicit val(EM_VAL handle) :
#ifdef _REENTRANT
thread(pthread_self()),
#endif
handle(handle) {}

// Whether this value is a uses incref/decref (true) or is a special reserved
// value (false).
Expand Down
8 changes: 4 additions & 4 deletions test/codesize/test_minimal_runtime_code_size_hello_embind_val.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"a.html.gz": 371,
"a.js": 5353,
"a.js.gz": 2524,
"a.wasm": 5798,
"a.wasm.gz": 2731,
"total": 11699,
"total_gz": 5626
"a.wasm": 5741,
"a.wasm.gz": 2690,
"total": 11642,
"total_gz": 5585
}
Loading