Remove remaining pthread function from WASM_WORKERS build#26487
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Mar 20, 2026
Merged
Remove remaining pthread function from WASM_WORKERS build#26487sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100 merged 2 commits intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
4cb407b to
80b40f3
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
80b40f3 to
1da8fe0
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 19, 2026
sbc100
added a commit
that referenced
this pull request
Mar 20, 2026
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
2 times, most recently
from
bf66e8b to
2b2c3fe
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 20, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 20, 2026
sbc100
added a commit
that referenced
this pull request
Mar 20, 2026
…n_futex_wait`. NFC (#26471) This reduces the number of places we need to breaking up our `wait` operation. It also means that other users the `emscripten_futex_wait` API don't break pthread proxying or async cancellation. This change removes one more place where we were erroneously calling `pthread_self()` in the Wasm Workers build of libc, so this change also makes the code less broken in the Wasm Worker case. Needed as part of #26487
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
2b2c3fe to
c92de04
Compare
This includes `pthread_self`, which is not valid to call in Wasm Workers.
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
c92de04 to
9034992
Compare
dschuff
approved these changes
Mar 20, 2026
Collaborator
Author
|
Actually instead of this I think we can just make them work now! #26510 |
Collaborator
Author
|
Actually I'm going to land this now and we can work on making the pthread API work in Wasm Workers as a followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove remaining pthread function from WASM_WORKERS build. NFC
This includes
pthread_self, along with the internal__get_tpfunction on which its bases.These are not valid to call in Wasm Workers.
This PR is currently stacked on top of #26471