Conversation
This fixes two isses: clipped glyphs for when the computed bounding box does not match the actual bounding box and glyphs leaking into others.
|
Looks good at first glance. Can you provide a font file which shows this issue, so that I can test it myself? I have another unmerged branch that might interfere with these changes and I want to make sure I don't accidentally break the fix again. |
| .glyphs | ||
| .iter() | ||
| .filter_map(|g| { | ||
| matches!(g.encoding, Encoding::Standard(_)) |
There was a problem hiding this comment.
Why does this ignore glyphs without a standard encoding?
There was a problem hiding this comment.
I am not too familiar with the codebase and followed basically what was done in line 104 and 116.
I am not sure if the font license allows redistributing but it should be fairly easy to reproduce. I used otf2bd to produce a 64 pixel tall rendition of Archivo Narrow with otf2bdf -r 72 -p 64 ArchivoNarrow-Regular.ttf -o archivo.bdf |
|
Thanks for the instructions to reproduce the issue. I've opened #50 as an alternative to this PR, which works similarly but ignores the font metrics entirely and just relies on the glyph bounding boxes. |
|
Closing in favor of #50. Thanks again for bringing this to my attention! |
2 participants
This fixes two isses: clipped glyphs for when the computed bounding box does not match the actual bounding box and glyphs leaking into others.