Remove url anchors in lsp--uri-to-path#4983
Open
themkat wants to merge 4 commits intoemacs-lsp:masterfrom
Open
Remove url anchors in lsp--uri-to-path#4983themkat wants to merge 4 commits intoemacs-lsp:masterfrom
themkat wants to merge 4 commits intoemacs-lsp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I thought about removing the "target" from the URL completely, but I found one test case:
As I understand it, we want
#to be in the resulting URL if is was encoded, but remove it if it was explicit. The big assumption is therefore that the uris we get will follow the rules of standard http paths. (I've never seen a address URL encode the anchor, only#symbols existing in text). I've added a test that illustrate my point and how I imagine language servers work with paths containing#. (though I have NEVER seen it IRL. Just assume from the tests and current code that it is wanted. Also read that#symbols in filenames are allowed, so we can probably assume that they are url encoded).Fixes #4976