Skip to content

feat: dedup text edits#4840

Open
cxa wants to merge 5 commits intoemacs-lsp:masterfrom
cxa:dedup-text-edits
Open

feat: dedup text edits#4840
cxa wants to merge 5 commits intoemacs-lsp:masterfrom
cxa:dedup-text-edits

Conversation

@cxa
Copy link

@cxa cxa commented Jul 19, 2025

For some reasons, text edits suggested from multiple LSP servers might be duplicated, see cxa/lsp-biome#11 or #4835.

This PR deduplicates text edits before applying.

@eder-pki
Copy link

Hey, there seems to be a problem with the build? The tests run correctly in windows but failed in ubuntu and macos.

@eder-pki
Copy link

@cxa could you rerun the tests?

@cxa
Copy link
Author

cxa commented Aug 27, 2025

@cxa could you rerun the tests?

I can't, this is not under my control.

@jcs090218
Copy link
Member

Interestingly, I'm also unable to re-run the tests. 🤔

@eder-pki
Copy link

@cxa @jcs090218 hey could you try to rerun the tests? this bug is still going on and I'm working with the change locally and works great.

@jcs090218
Copy link
Member

It looks like the test fails.

@cxa cxa requested a review from eder-pki January 24, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants