Add another example to Integer.parse/1#15101
Merged
josevalim merged 4 commits intoelixir-lang:mainfrom Feb 12, 2026
Merged
Conversation
"Remainder" does not mean the mathematical definition of the term.
Member
|
Maybe we can actually also reword the docs to call it "rest of the string" instead of "remainder"? |
The term has a mathematical definition, which does not apply here and might be confusing.
Contributor
Author
|
If you are not sure about my new example, I can change it. I am working with classical archaeologists, otherwise I do not know why I landed on this one. 😉 |
davydog187
reviewed
Feb 11, 2026
Co-authored-by: Dave Lucia <dave@tvlabs.ai>
josevalim
reviewed
Feb 12, 2026
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Remainder" does not mean the mathematical definition of the term.
I just tripped over this and thought maybe another, explicitly weird example might be helpful.