Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EIC container Spack environment to use the first tagged release of eic-opticks (v0.1.0), and adjusts the pinned eic/eic-spack repository revision accordingly.
Changes:
- Pin
eic-opticksto@0.1.0in the shared Spackpackages.yaml. - Update
EICSPACK_VERSIONineic-spack.shto a newer commit SHA.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Switches eic-opticks requirement from a commit-based version to the 0.1.0 tag. |
| eic-spack.sh | Moves the pinned eic/eic-spack revision to a newer SHA (currently annotated with # FIXME). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First tagged release