Remove pre-built indexes for Eclipse Help system#382
Merged
MatthewKhouzam merged 1 commit intoeclipse-tracecompass:masterfrom Mar 12, 2026
Merged
Remove pre-built indexes for Eclipse Help system#382MatthewKhouzam merged 1 commit intoeclipse-tracecompass:masterfrom
MatthewKhouzam merged 1 commit intoeclipse-tracecompass:masterfrom
Conversation
This change fixes errors when doing a Help -> Contents and then initiating a search. Errors such as: ``` !ENTRY org.eclipse.help.base 2 0 2026-03-11 13:55:32.290 !MESSAGE Unable to consume Lucene index from bundle 'org.eclipse.tracecompass.doc.user_11.2.0.202512122003 [236]'. The index should be rebuilt with Lucene 10.3.2 ``` or ``` !ENTRY org.eclipse.help.base 4 0 2026-03-11 14:34:35.767 !MESSAGE Help index declared, but missing for plugin org.eclipse.tracecompass.incubator.ros2.doc.user. ``` The latter error generally happens for the incubator because the skeleton included building the index, but the build.properties was missing the the `index/` entry, so they were not included in built bundles. See eclipse-simrel/simrel.build#1288
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
💤 Files with no reviewable changes (19)
📝 WalkthroughWalkthroughThis pull request systematically removes help index generation from eight Eclipse Trace Compass documentation modules. The changes eliminate index-related entries from build properties, Ant build files, plugin manifests, and Maven build configurations across the project, plus removes the root-level help documentation Eclipse run repository property. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MatthewKhouzam
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This change fixes errors when doing a Help -> Contents and then initiating a search.
Errors such as:
or
The latter error generally happens for the incubator because the skeleton included building the index, but the build.properties was missing the the
index/entry, so they were not included in built bundles.See eclipse-simrel/simrel.build#1288
How to test
Follow-ups
Review checklist
Summary by CodeRabbit