Open
Conversation
Change-Id: If0da1961e04026a59bbdb66c82089a85256ca39c Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
📝 WalkthroughWalkthroughA comprehensive version bump across the Eclipse TraceCompass project, updating all component versions from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT. Changes span Maven pom.xml files, OSGi bundle manifests, feature descriptors, and product configurations with no functional logic modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
rcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xml (1)
64-64:⚠️ Potential issue | 🟠 MajorModule version not updated to 11.3.0-SNAPSHOT.
The parent version was correctly updated to 11.3.0-SNAPSHOT (line 19), but the module's own
<version>at line 64 remains 11.2.0-SNAPSHOT. For a release bump, this should be updated to 11.3.0-SNAPSHOT to maintain consistency with the branding feature versioning.
,🔧 Proposed fix
-<version>11.2.0-SNAPSHOT</version> +<version>11.3.0-SNAPSHOT</version>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@rcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xml` at line 64, The module's own <version> element still reads "11.2.0-SNAPSHOT" while the parent <version> was bumped to "11.3.0-SNAPSHOT"; update the module's <version> value to "11.3.0-SNAPSHOT" in the pom.xml (the module <version> element) so it matches the parent <version> and branding feature versioning.doc/org.eclipse.tracecompass.doc.user/pom.xml (1)
131-131:⚠️ Potential issue | 🟡 MinorMissed version bump: project version still shows 11.2.0-SNAPSHOT.
The parent version was updated to 11.3.0-SNAPSHOT on line 19, but the project's own
<version>element on line 131 remains at 11.2.0-SNAPSHOT. This creates a version mismatch within the same module.,
Proposed fix
-<version>11.2.0-SNAPSHOT</version> +<version>11.3.0-SNAPSHOT</version>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@doc/org.eclipse.tracecompass.doc.user/pom.xml` at line 131, The project's own <version> element still reads 11.2.0-SNAPSHOT while the parent was bumped to 11.3.0-SNAPSHOT; update the project's <version> element to 11.3.0-SNAPSHOT so the module version matches the parent and removes the inconsistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@doc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xml`:
- Line 19: Update this module's <version> element to match the parent: change
the existing <version>11.2.0-SNAPSHOT</version> entry in the POM to
<version>11.3.0-SNAPSHOT</version> so the doc plug-in is on the same
11.3.0-SNAPSHOT release line as the parent.
In `@doc/org.eclipse.tracecompass.doc.dev/pom.xml`:
- Line 19: The module's <version> element in the pom.xml is still set to
11.2.0-SNAPSHOT while the parent and bundle manifest use 11.3.0; update the
module's <version> tag value from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so all
declared versions (parent, module <version>, and bundle manifest) match; locate
the module-level <version> element in the pom and change its text to
"11.3.0-SNAPSHOT".
In `@doc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xml`:
- Line 19: The module POM still pins its own version to 11.2.0-SNAPSHOT (the
<version> element later in the file) while the parent was bumped to
11.3.0-SNAPSHOT; update that module-level <version> (the occurrence currently
set to 11.2.0-SNAPSHOT around line 127) to 11.3.0-SNAPSHOT so the doc artifact
and module metadata match the parent bump.
In `@doc/org.eclipse.tracecompass.rcp.doc.user/pom.xml`:
- Line 19: The module's own <version> element still reads 11.2.0-SNAPSHOT while
the parent was bumped to 11.3.0-SNAPSHOT; update the module's <version> (the
<version>11.2.0-SNAPSHOT</version> entry referenced in the pom) to
11.3.0-SNAPSHOT so the published artifact metadata matches the parent's
11.3.0-SNAPSHOT release train.
In `@doc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xml`:
- Line 19: Update the module's own <version> element to match the parent change:
replace the module <version> value currently set to 11.2.0-SNAPSHOT with
11.3.0-SNAPSHOT so the module and parent versions are consistent (update the
<version> tag that corresponds to the module declaration near the bottom of the
POM).
In `@rcp/org.eclipse.tracecompass.rcp.branding/pom.xml`:
- Around line 21-24: The module's <version> declared as 11.2.0-SNAPSHOT must be
updated to match the parent POM's 11.3.0-SNAPSHOT; locate the <version> element
in rcp/org.eclipse.tracecompass.rcp.branding/pom.xml (the module version tag)
and change its value from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so the module,
parent, bundle manifest, feature, and product metadata are consistent.
In `@rcp/org.eclipse.tracecompass.rcp.product/pom.xml`:
- Around line 16-20: The POM's parent version was updated to 11.3.0-SNAPSHOT but
the module-level version property (the value used by ${unqualifiedVersion}) is
still set to 11.2.0-SNAPSHOT; update the module/version property that defines
unqualifiedVersion from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so the artifact
naming (${unqualifiedVersion}) and product metadata match the new parent version
(look for the unqualifiedVersion property and the module <version> element in
this pom.xml).
In `@rcp/org.eclipse.tracecompass.rcp/pom.xml`:
- Line 19: Update the module's own <version> element to match the parent: change
the <version> value currently set to 11.2.0-SNAPSHOT (the module <version>
element) to 11.3.0-SNAPSHOT so the module and parent versions are consistent for
the 11.3.0 release.
---
Outside diff comments:
In `@doc/org.eclipse.tracecompass.doc.user/pom.xml`:
- Line 131: The project's own <version> element still reads 11.2.0-SNAPSHOT
while the parent was bumped to 11.3.0-SNAPSHOT; update the project's <version>
element to 11.3.0-SNAPSHOT so the module version matches the parent and removes
the inconsistency.
In `@rcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xml`:
- Line 64: The module's own <version> element still reads "11.2.0-SNAPSHOT"
while the parent <version> was bumped to "11.3.0-SNAPSHOT"; update the module's
<version> value to "11.3.0-SNAPSHOT" in the pom.xml (the module <version>
element) so it matches the parent <version> and branding feature versioning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0e4420f2-bb2b-449e-b2a7-949a1df02a9c
📒 Files selected for processing (120)
analysis/org.eclipse.tracecompass.analysis.counters.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.counters.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.graph.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.lami.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.lami.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.ui.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.profiling.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.profiling.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.timing.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.timing.ui.swtbot.tests/pom.xmlanalysis/pom.xmlbtf/org.eclipse.tracecompass.btf.core.tests/pom.xmlbtf/org.eclipse.tracecompass.btf/feature.xmlbtf/pom.xmlcommon/org.eclipse.tracecompass.common.core.tests/pom.xmlcommon/pom.xmlctf/org.eclipse.tracecompass.ctf.core.tests/pom.xmlctf/org.eclipse.tracecompass.ctf.parser.tests/pom.xmlctf/org.eclipse.tracecompass.ctf.parser/pom.xmlctf/org.eclipse.tracecompass.ctf/feature.xmlctf/org.eclipse.tracecompass.tmf.ctf.core.tests/pom.xmlctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xmlctf/org.eclipse.tracecompass.tmf.ctf/feature.xmlctf/pom.xmldoc/org.eclipse.tracecompass.analysis.profiling.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xmldoc/org.eclipse.tracecompass.doc.dev/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.doc.dev/pom.xmldoc/org.eclipse.tracecompass.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.doc.user/pom.xmldoc/org.eclipse.tracecompass.gdbtrace.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xmldoc/org.eclipse.tracecompass.rcp.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.rcp.doc.user/pom.xmldoc/org.eclipse.tracecompass.tmf.pcap.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xmldoc/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace/feature.xmlgdbtrace/pom.xmljsontrace/org.eclipse.tracecompass.jsontrace.core.tests/pom.xmljsontrace/org.eclipse.tracecompass.jsontrace/feature.xmljsontrace/pom.xmllttng/org.eclipse.tracecompass.lttng2.common.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.ui.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control/feature.xmllttng/org.eclipse.tracecompass.lttng2.kernel.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.kernel/feature.xmllttng/org.eclipse.tracecompass.lttng2.ust.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust/feature.xmllttng/pom.xmlpcap/org.eclipse.tracecompass.pcap.core.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap.core.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap/feature.xmlpcap/pom.xmlpom.xmlrcp/org.eclipse.tracecompass.rcp.branding.feature/feature.xmlrcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xmlrcp/org.eclipse.tracecompass.rcp.branding/META-INF/MANIFEST.MFrcp/org.eclipse.tracecompass.rcp.branding/plugin.xmlrcp/org.eclipse.tracecompass.rcp.branding/pom.xmlrcp/org.eclipse.tracecompass.rcp.incubator/feature.xmlrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.23-e4.25/tracing.productrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.26-e4.29/tracing.productrcp/org.eclipse.tracecompass.rcp.product/legacy/tracing.productrcp/org.eclipse.tracecompass.rcp.product/pom.xmlrcp/org.eclipse.tracecompass.rcp.product/tracing.productrcp/org.eclipse.tracecompass.rcp.rcptt.tests/pom.xmlrcp/org.eclipse.tracecompass.rcp.ui.tests/pom.xmlrcp/org.eclipse.tracecompass.rcp.ui/META-INF/MANIFEST.MFrcp/org.eclipse.tracecompass.rcp/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.30/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.32/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.33/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.34/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.35/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.36/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.37/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy/feature.xmlrcp/org.eclipse.tracecompass.rcp/pom.xmlrcp/pom.xmlreleng/org.eclipse.tracecompass.alltests/pom.xmlreleng/org.eclipse.tracecompass.integration.core.tests/pom.xmlreleng/org.eclipse.tracecompass.integration.swtbot.tests/pom.xmlreleng/org.eclipse.tracecompass.releng-site/pom.xmlreleng/org.eclipse.tracecompass.target/pom.xmlreleng/org.eclipse.tracecompass.testing/feature.xmlreleng/pom.xmlstatesystem/org.eclipse.tracecompass.datastore.core.tests/pom.xmlstatesystem/org.eclipse.tracecompass.segmentstore.core.tests/pom.xmlstatesystem/org.eclipse.tracecompass.statesystem.core.tests/pom.xmlstatesystem/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.cli.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.cli/feature.xmltmf/org.eclipse.tracecompass.tmf.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.filter.parser/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote/feature.xmltmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.ui/pom.xmltmf/org.eclipse.tracecompass.tmf/feature.xmltmf/pom.xml
| <artifactId>org.eclipse.tracecompass.doc</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Bump the module version too.
The parent moves to 11.3.0-SNAPSHOT, but this POM still declares 11.2.0-SNAPSHOT at Line 125. That would leave this doc plug-in on the old release line during 11.3.0 prep.
Suggested fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@doc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xml` at line 19,
Update this module's <version> element to match the parent: change the existing
<version>11.2.0-SNAPSHOT</version> entry in the POM to
<version>11.3.0-SNAPSHOT</version> so the doc plug-in is on the same
11.3.0-SNAPSHOT release line as the parent.
| <artifactId>org.eclipse.tracecompass.doc</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== doc/org.eclipse.tracecompass.doc.dev/pom.xml =="
rg -n '<artifactId>org\.eclipse\.tracecompass\.doc\.dev</artifactId>|<parent>|</parent>|<version>11\.(2|3)\.0-SNAPSHOT' \
doc/org.eclipse.tracecompass.doc.dev/pom.xml
echo
echo "== Local bundle manifest, if present =="
fd 'MANIFEST\.MF' doc/org.eclipse.tracecompass.doc.dev -t f -x rg -n 'Bundle-SymbolicName|Bundle-Version|11\.(2|3)\.0' {}
echo
echo "== Doc feature references =="
rg -n -C2 'org\.eclipse\.tracecompass\.doc\.dev|11\.(2|3)\.0' doc -g 'feature.xml'Repository: eclipse-tracecompass/org.eclipse.tracecompass
Length of output: 490
Update module version to 11.3.0-SNAPSHOT in pom.xml line 127.
The module's local <version> tag (line 127) declares 11.2.0-SNAPSHOT, but the parent version (line 19) and the bundle manifest both declare 11.3.0. This mismatch was missed during the release bump and must be corrected.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@doc/org.eclipse.tracecompass.doc.dev/pom.xml` at line 19, The module's
<version> element in the pom.xml is still set to 11.2.0-SNAPSHOT while the
parent and bundle manifest use 11.3.0; update the module's <version> tag value
from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so all declared versions (parent, module
<version>, and bundle manifest) match; locate the module-level <version> element
in the pom and change its text to "11.3.0-SNAPSHOT".
Contributor
There was a problem hiding this comment.
@MatthewKhouzam coderabbit comment is why the build is failing:
From here in build log
Error: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:4.0.11:validate-version (default-validate-version) on project org.eclipse.tracecompass.doc.dev: Unqualified OSGi version 11.3.0.qualifier must match unqualified Maven version 11.2.0-SNAPSHOT for SNAPSHOT builds -> [Help 1]
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
| <artifactId>org.eclipse.tracecompass.doc</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Update the module's own version as well.
This parent bump is incomplete while Line 127 still pins the module to 11.2.0-SNAPSHOT. For a repo-wide 11.3.0 release, this will keep the doc artifact on the old version metadata.
Suggested fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>Also applies to: 127-127
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@doc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xml` at line 19, The
module POM still pins its own version to 11.2.0-SNAPSHOT (the <version> element
later in the file) while the parent was bumped to 11.3.0-SNAPSHOT; update that
module-level <version> (the occurrence currently set to 11.2.0-SNAPSHOT around
line 127) to 11.3.0-SNAPSHOT so the doc artifact and module metadata match the
parent bump.
| <artifactId>org.eclipse.tracecompass.doc</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Bump the module version too.
The parent is on 11.3.0-SNAPSHOT, but this module still declares 11.2.0-SNAPSHOT at Line 127. That leaves the published artifact metadata on the previous release train even though this PR is aligning the repo to 11.3.0.
Suggested fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>Also applies to: 127-127
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@doc/org.eclipse.tracecompass.rcp.doc.user/pom.xml` at line 19, The module's
own <version> element still reads 11.2.0-SNAPSHOT while the parent was bumped to
11.3.0-SNAPSHOT; update the module's <version> (the
<version>11.2.0-SNAPSHOT</version> entry referenced in the pom) to
11.3.0-SNAPSHOT so the published artifact metadata matches the parent's
11.3.0-SNAPSHOT release train.
| <artifactId>org.eclipse.tracecompass.doc</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Version mismatch: module version not updated.
The parent version was updated to 11.3.0-SNAPSHOT on line 19, but the module's own <version> on line 127 is still 11.2.0-SNAPSHOT. This should be updated to match the release version.
Proposed fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>Also applies to: 127-127
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@doc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xml` at line 19, Update
the module's own <version> element to match the parent change: replace the
module <version> value currently set to 11.2.0-SNAPSHOT with 11.3.0-SNAPSHOT so
the module and parent versions are consistent (update the <version> tag that
corresponds to the module declaration near the bottom of the POM).
Comment on lines
21
to
+24
| <parent> | ||
| <artifactId>org.eclipse.tracecompass.rcp-parent</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== rcp/org.eclipse.tracecompass.rcp.branding/pom.xml =="
rg -n '<artifactId>org\.eclipse\.tracecompass\.rcp\.branding</artifactId>|<parent>|</parent>|<version>11\.(2|3)\.0-SNAPSHOT' \
rcp/org.eclipse.tracecompass.rcp.branding/pom.xml
echo
echo "== Branding bundle manifest =="
fd 'MANIFEST\.MF' rcp/org.eclipse.tracecompass.rcp.branding -t f -x rg -n 'Bundle-SymbolicName|Bundle-Version|11\.(2|3)\.0' {}
echo
echo "== Related branding feature/product metadata =="
rg -n 'org\.eclipse\.tracecompass\.rcp\.branding|version="11\.(2|3)\.0\.qualifier"|Version: 11\.(2|3)\.0' \
rcp/org.eclipse.tracecompass.rcp.branding.feature/feature.xml \
rcp/org.eclipse.tracecompass.rcp.product/tracing.product \
rcp/org.eclipse.tracecompass.rcp.product/legacy-e4.23-e4.25/tracing.product \
rcp/org.eclipse.tracecompass.rcp.product/legacy-e4.26-e4.29/tracing.productRepository: eclipse-tracecompass/org.eclipse.tracecompass
Length of output: 6483
Update the module version to match the parent.
Line 27 declares 11.2.0-SNAPSHOT while the parent POM (line 24), bundle manifest, feature, and all product metadata are at 11.3.0. The local module version must be updated to 11.3.0-SNAPSHOT to maintain consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rcp/org.eclipse.tracecompass.rcp.branding/pom.xml` around lines 21 - 24, The
module's <version> declared as 11.2.0-SNAPSHOT must be updated to match the
parent POM's 11.3.0-SNAPSHOT; locate the <version> element in
rcp/org.eclipse.tracecompass.rcp.branding/pom.xml (the module version tag) and
change its value from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so the module, parent,
bundle manifest, feature, and product metadata are consistent.
Comment on lines
16
to
20
| <parent> | ||
| <artifactId>org.eclipse.tracecompass.rcp-parent</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> | ||
| </parent> |
There was a problem hiding this comment.
Bump the module version here as well.
This POM still declares 11.2.0-SNAPSHOT at Line 309, so ${unqualifiedVersion} on Line 30 will keep naming the RCP archives as 11.2.0 even though the module has moved to the 11.3.0 parent. That leaves the product metadata out of sync with the release train.
Suggested fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rcp/org.eclipse.tracecompass.rcp.product/pom.xml` around lines 16 - 20, The
POM's parent version was updated to 11.3.0-SNAPSHOT but the module-level version
property (the value used by ${unqualifiedVersion}) is still set to
11.2.0-SNAPSHOT; update the module/version property that defines
unqualifiedVersion from 11.2.0-SNAPSHOT to 11.3.0-SNAPSHOT so the artifact
naming (${unqualifiedVersion}) and product metadata match the new parent version
(look for the unqualifiedVersion property and the module <version> element in
this pom.xml).
| <artifactId>org.eclipse.tracecompass.rcp-parent</artifactId> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <version>11.2.0-SNAPSHOT</version> | ||
| <version>11.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Version mismatch: module version not updated.
The parent version was updated to 11.3.0-SNAPSHOT on line 19, but the module's own <version> on line 140 is still 11.2.0-SNAPSHOT. This inconsistency should be corrected for the 11.3.0 release.
Proposed fix
-<version>11.2.0-SNAPSHOT</version>
+<version>11.3.0-SNAPSHOT</version>Also applies to: 140-140
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rcp/org.eclipse.tracecompass.rcp/pom.xml` at line 19, Update the module's own
<version> element to match the parent: change the <version> value currently set
to 11.2.0-SNAPSHOT (the module <version> element) to 11.3.0-SNAPSHOT so the
module and parent versions are consistent for the 11.3.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
release 11.3.0
How to test
Passes CI
Follow-ups
Review checklist
Summary by CodeRabbit