hmon: add heartbeat monitor by arkjedrz · Pull Request #67 · eclipse-score/lifecycle

arkjedrz · 2026-02-09T15:43:16Z

Add heartbeat monitor HMON.

Resolves #68

github-actions · 2026-02-09T15:44:17Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: d74593c4-ca89-43be-8999-df68d28af178
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (64 packages loaded, 9 targets configured)

Analyzing: target //:license-check (89 packages loaded, 9 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2462 targets configured)

Analyzing: target //:license-check (154 packages loaded, 3485 targets configured)

Analyzing: target //:license-check (155 packages loaded, 7715 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7899 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (167 packages loaded, 8025 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9913 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.873s, Critical Path: 2.67s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-02-09T15:45:35Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

Adds a new heartbeat monitor (HMON) to the Rust health monitoring library and integrates it into the existing monitoring worker/supervisor notification flow.

Changes:

Introduces heartbeat module (monitor + atomic state) and integrates heartbeat monitors into HealthMonitorBuilder/HealthMonitor.
Updates the monitor evaluation interface to accept a shared hmon_starting_point and wires it through the monitoring worker thread.
Refactors SupervisorAPIClient into a dedicated module with selectable implementations via Cargo features.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/health_monitoring_lib/rust/worker.rs	Passes a shared HMON start instant into monitor evaluations; moves supervisor client trait out.
src/health_monitoring_lib/rust/supervisor_api_client/mod.rs	Adds feature-selected `SupervisorAPIClient` + implementation alias.
src/health_monitoring_lib/rust/supervisor_api_client/stub_supervisor_api_client.rs	New stub client implementation.
src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs	New SCORE client implementation.
src/health_monitoring_lib/rust/lib.rs	Adds heartbeat monitors to builder + start flow; uses new supervisor client impl selector.
src/health_monitoring_lib/rust/heartbeat/mod.rs	Exposes heartbeat monitor API.
src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs	Adds atomic packed heartbeat state and tests.
src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs	Implements heartbeat monitor logic + tests (incl. loom).
src/health_monitoring_lib/rust/deadline/deadline_monitor.rs	Adapts deadline evaluation to new evaluator signature and shared start instant.
src/health_monitoring_lib/rust/common.rs	Extends evaluation error types; adds `duration_to_u32`; updates evaluator trait signature.
src/health_monitoring_lib/Cargo.toml	Adds optional `monitor_rs`, loom target dep, and feature defaults.
src/health_monitoring_lib/BUILD	Enables `score_supervisor_api_client` feature in Bazel builds.
Cargo.toml	Updates workspace defaults and adds `cfg(loom)` lint configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

src/health_monitoring_lib/rust/deadline/deadline_monitor.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

src/health_monitoring_lib/rust/supervisor_api_client/mod.rs

src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs

src/health_monitoring_lib/rust/supervisor_api_client/mod.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/Cargo.toml

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/rust/common.rs

src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs

src/health_monitoring_lib/rust/supervisor_api_client/stub_supervisor_api_client.rs

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

.github/workflows/lint_clippy.yml

pawelrutkaq · 2026-03-04T10:04:40Z

FYI: We are still dropping a refactor on this code today, as we discussed after review with @arkjedrz

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs

Add heartbeat monitor HMON.

Rework heartbeat monitor state into two atomics.

- Add new constructor to `TimeRange`. - Rework `time_offset`. - Update state using `compare_exchange`. - Other code, docs, comments fixes.

Use swap to read and reset state in single operation.

NicolasFussberger · 2026-03-06T09:05:13Z

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

+        // Check current counter state.
+        let counter = snapshot.counter();
+        // Disallow multiple heartbeats in same heartbeat cycle.
+        if counter > 1 {


Do I understand correctly that there are some hard constraints on the internal_processing_cycle time for this to work. It must be chosen so that evaluate() is always called at the right time such at it never spans across two alive intervals.

In case multiple heartbeat monitors are configured, I wonder if you can find a suitable internal_processing_cycle such that this works?

I guess it works when you choose a very frequent internal_processing_cycle. Is this understanding correct?

Not sure if I understand Your diagram correctly:

If it represents a single monitor, then a correct heartbeat is a beginning of a new processing cycle - everything after the first heartbeat is irrelevant in the first line.

If it represents multiple monitors then heartbeats land at different monitors and their timelines are separate.

Internal processing cycle frequency must be twice as large as largest heartbeat frequency required by any monitor. Not sure if that's a Nyquist frequency, but the rough idea remains the same.

Yes, its has to be < min(mon1.min, mon2.min,...)*2. This is what I thin we discussed at the beginning, that the internal cycle is separate from the supervisor api notification cycle to be able to tune it because it makse no sense to have ie hearbeat every 10ms and detecting failure only every 100ms. Should we change that idea, the more sophisticated alorithmi is needed, since You need to store up to N samples (then how N is defined etc)

Ok understood, thanks for the clarification. This means use cases where there is no clear lower bound for the heartbeat are not supported by the heartbeat monitor and in this case you might use a deadline instead.

Np. We can always decide later that we need extensions here, but this will not affect the user API

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

pawelrutkaq · 2026-03-06T09:31:27Z

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

+        // Check current counter state.
+        let counter = snapshot.counter();
+        // Disallow multiple heartbeats in same heartbeat cycle.
+        if counter > 1 {


Yes, its has to be < min(mon1.min, mon2.min,...)*2. This is what I thin we discussed at the beginning, that the internal cycle is separate from the supervisor api notification cycle to be able to tune it because it makse no sense to have ie hearbeat every 10ms and detecting failure only every 100ms. Should we change that idea, the more sophisticated alorithmi is needed, since You need to store up to N samples (then how N is defined etc)

src/health_monitoring_lib/rust/common.rs

- Change `from_interval` params. - Add `new_internal` for later FFI usage. - Change message in `duration_to_int`.

arkjedrz requested a review from pawelrutkaq February 9, 2026 15:43

arkjedrz had a problem deploying to workflow-approval February 9, 2026 15:43 — with GitHub Actions Failure

arkjedrz requested a review from Copilot February 9, 2026 15:43

Copilot AI reviewed Feb 9, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from f07c0db to e65f6a6 Compare February 10, 2026 11:43

arkjedrz temporarily deployed to workflow-approval February 10, 2026 11:43 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot February 10, 2026 11:44

Copilot AI reviewed Feb 10, 2026

View reviewed changes

src/health_monitoring_lib/Cargo.toml Outdated Show resolved Hide resolved

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs Outdated Show resolved Hide resolved

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs Outdated Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from e65f6a6 to bd438c3 Compare February 10, 2026 12:57

arkjedrz temporarily deployed to workflow-approval February 10, 2026 12:57 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from bd438c3 to c5f4b84 Compare February 10, 2026 13:14

arkjedrz had a problem deploying to workflow-approval February 10, 2026 13:14 — with GitHub Actions Failure

arkjedrz requested a review from Copilot February 10, 2026 13:15

Copilot AI reviewed Feb 10, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from c5f4b84 to b012f37 Compare February 10, 2026 13:19

arkjedrz temporarily deployed to workflow-approval February 10, 2026 13:19 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot February 10, 2026 13:19

Copilot AI reviewed Feb 10, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from b012f37 to 862da21 Compare February 11, 2026 12:14

arkjedrz temporarily deployed to workflow-approval February 11, 2026 12:14 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from 862da21 to 59c92ee Compare February 13, 2026 14:48

arkjedrz temporarily deployed to workflow-approval February 13, 2026 14:48 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from 59c92ee to cf14efb Compare February 17, 2026 12:12

arkjedrz temporarily deployed to workflow-approval February 17, 2026 12:12 — with GitHub Actions Inactive

arkjedrz self-assigned this Feb 17, 2026

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from cf14efb to 67fe6cc Compare February 25, 2026 09:30

arkjedrz temporarily deployed to workflow-approval March 3, 2026 10:16 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from a8b11fc to ef78463 Compare March 3, 2026 12:39

arkjedrz temporarily deployed to workflow-approval March 3, 2026 12:39 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from ef78463 to 3816630 Compare March 4, 2026 09:35

arkjedrz requested a deployment to workflow-approval March 4, 2026 09:36 — with GitHub Actions Waiting

pawelrutkaq mentioned this pull request Mar 4, 2026

hmon: add C++ interface to heartbeat monitor #72

Merged

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from 3816630 to 27766ce Compare March 4, 2026 11:32

arkjedrz requested a deployment to workflow-approval March 4, 2026 11:33 — with GitHub Actions Waiting

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from 27766ce to 77da130 Compare March 4, 2026 11:34

arkjedrz requested a deployment to workflow-approval March 4, 2026 11:34 — with GitHub Actions Waiting

arkjedrz force-pushed the arkjedrz_heartbeat-monitor branch from 77da130 to 125905c Compare March 4, 2026 13:54

arkjedrz temporarily deployed to workflow-approval March 4, 2026 13:54 — with GitHub Actions Inactive

pawelrutkaq requested changes Mar 5, 2026

View reviewed changes

arkjedrz added 3 commits March 6, 2026 09:32

hmon: add heartbeat monitor

a068217

Add heartbeat monitor HMON.

hmon: rework heartbeat monitor state

81db97c

Rework heartbeat monitor state into two atomics.

hmon: heartbeat monitor post-review

6618050

- Add new constructor to `TimeRange`. - Rework `time_offset`. - Update state using `compare_exchange`. - Other code, docs, comments fixes.

eelcoem approved these changes Mar 6, 2026

View reviewed changes

hmon: single sync in evaluate

729ddbd

Use swap to read and reset state in single operation.

NicolasFussberger reviewed Mar 6, 2026

View reviewed changes

pawelrutkaq requested changes Mar 6, 2026

View reviewed changes

NicolasFussberger approved these changes Mar 6, 2026

View reviewed changes

hmon: TimeRange and duration_to_int changes

f3e4c82

- Change `from_interval` params. - Add `new_internal` for later FFI usage. - Change message in `duration_to_int`.

pawelrutkaq approved these changes Mar 6, 2026

View reviewed changes

Conversation

arkjedrz commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pawelrutkaq commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NicolasFussberger Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkjedrz Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pawelrutkaq Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkjedrz commented Feb 9, 2026 •

edited

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading

NicolasFussberger Mar 6, 2026 •

edited

Loading