Rust::com Interface declarative macro for com-api#159
Rust::com Interface declarative macro for com-api#159bharatGoswami8 wants to merge 5 commits intoeclipse-score:mainfrom
Conversation
* Enabled the interface and dependent type generation with macro for user
score/mw/com/impl/rust/com-api/com-api-concept-macros/interface_macros.rs
Outdated
Show resolved
Hide resolved
* Moved interface macro file from macro to concept crate * Auto ID added with Module Path * Created lib crate root for concept module
score/mw/com/impl/rust/com-api/com-api-concept/interface_macros.rs
Outdated
Show resolved
Hide resolved
* Added document test for interface macro
bharatGoswami8
force-pushed
the
declarative_macro_for_interface
branch
from
fa1d2b7 to
4273929
Compare
* validate the ID and type generated from macro
|
|
||
| #[doc(hidden)] | ||
| #[allow(unused_imports)] | ||
| pub use paste; |
There was a problem hiding this comment.
no external deps please.
There was a problem hiding this comment.
Regarding the external crate dependency will have discussion on score-rust-infrastructure meeting.
score/mw/com/impl/rust/com-api/com-api-concept/interface_macros.rs
Outdated
Show resolved
Hide resolved
score/mw/com/impl/rust/com-api/com-api-concept/interface_macros.rs
Outdated
Show resolved
Hide resolved
score/mw/com/impl/rust/com-api/com-api-concept/interface_macros.rs
Outdated
Show resolved
Hide resolved
|
PR using |
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
For me all fine except paste! crate usage as its not clear what to do with certificaiton of it,
|
I would suggest to accept the change as-is and open a ticket so that we keep track of this issue. If we know how to treat external crates in safety critical code, we can keep it as-is if it gets qualified, or remove it at some point and resort to a proc macro. Other options like forking paste or reimplement it just do not make sense to me. |
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
@darkwisebear @bharatGoswami8 fine with the approach for me. Maybe in code just mark that usage for paste! The crate is still under evaluation for safety and may be changed.
|
@darkwisebear , @pawelrutkaq , |
3 participants
eclipse-score/score#2561