-
Notifications
You must be signed in to change notification settings - Fork 0
Measurement MWP #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damskii9992
wants to merge
32
commits into
develop
Choose a base branch
from
Measurement_MWP
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Measurement MWP #21
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ab9ca22
Create Measurement from Scipp DataArray
damskii9992 dd022c0
Create Measurement from scitiff
damskii9992 0ad0876
Create Measurement from a regular TIFF stack
damskii9992 9496cfd
Merge branch 'develop' into Measurement_MWP
damskii9992 06c4ab1
Test all Measurement constructors
damskii9992 3c60b65
add rebinning part 1
damskii9992 67524e6
Ensure x and y coordinates are always bin-edges.
damskii9992 ed4401e
allow rebinning in 'x' or 'y'
damskii9992 83e59d5
First rebin unit tests
damskii9992 bb30f41
Final tests of rebin
damskii9992 3693d5b
Add plotting function to Measurement
damskii9992 540e95b
Add the interactive slicer plot from plopp to Measurement
damskii9992 27d9139
Add interactive inspector plot to Measurement class
damskii9992 dd33e66
Add Rectangular Region of Interest class
damskii9992 8b477cf
Add RectROI
damskii9992 4cb2400
Commit to possibly WFH
damskii9992 2648730
Require both x and y coordinates simultaniously.
damskii9992 85e0df7
add x_positions and y_positions setters and getters
damskii9992 b929e03
commit to WFH
damskii9992 c089eeb
commit to continue from office
damskii9992 59e2664
finish spectrum method and tests. Changed RectROI slice method to acc…
damskii9992 feef236
Add spectrum plotter
damskii9992 8142d72
Remove temporary plotting notebook
damskii9992 071883f
Update example notebook
damskii9992 d4d20fa
Add ROI creator method
damskii9992 4d3fbe3
Remove custom coords handling. Scipp now preserves coords when resizing.
damskii9992 1f4483a
Pr comments first batch
damskii9992 3658266
Add to_dict and from_dict methods to RectROI
damskii9992 0e3e76d
Adressing PR comments
damskii9992 716a0f5
Update plotting unit tests
damskii9992 de17e30
Add roi_creator test to test creating an ROI
damskii9992 c4a1397
Add save_scitiff method
damskii9992 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you need to have the same file in two different places in the project? |
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,3 +10,7 @@ | |
| __version__ = '0.0.0' | ||
|
|
||
| del importlib | ||
|
|
||
| from .measurement import Measurement | ||
|
|
||
| __all__ = [Measurement] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from .measurement import Measurement | ||
|
|
||
| __all__ = [Measurement] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.