Add basic templates of visualisation charts utilized in EasyTexture #30
Open
Add basic templates of visualisation charts utilized in EasyTexture #30
Conversation
…nd 2d plots using rectangular patches
AndrewSazonov
requested changes
Mar 23, 2026
| trace.theta = newData.theta | ||
| trace.marker.color = newData.z | ||
| trace.marker.cmin = Math.min(newData.z) | ||
| trace.marker.cmax = Math.min(newData.z) |
Member
There was a problem hiding this comment.
Should this be Math.max(newData.z) instead?
Comment on lines
-22
to
-24
| setXAxisTitle() | ||
| setYAxisTitle() | ||
| setXyData() |
Member
There was a problem hiding this comment.
If setXAxisTitle(), setYAxisTitle(), and setXyData() (now setPlotData()) are not called after the HTML page finishes loading, then the chart keeps using the default values hardcoded in the HTML template, not the values already set in the QML wrapper.
| property bool loadSucceededStatus: false | ||
| property string xAxisTitle: '' | ||
| property string yAxisTitle: '' | ||
| property string colorbarTitle: '' |
Member
There was a problem hiding this comment.
colorbarTitle is introduced in Plotly2dHeatmap.qml, but the expected chain to propagate this change to the HTML template seems to be missing. Unlike Plotly2dPolarHeatmap.qml, I do not see onColorbarTitleChanged -> setColorbarTitle() here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several new templates necessary for visualisations in EasyTexture, as well as modifications to existing templates used there.