feat: add HuggingFace for ListTaskEntriesRequest#625
Merged
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for HuggingFace protocol information to the
ListTaskEntriesRequestmessage across the codebase, including protobuf definitions, Rust structs, and validation logic. This enhancement allows the API to handle HuggingFace-specific data, improving extensibility for machine learning workflows.Add support for HuggingFace protocol information:
Protobuf and Rust API changes
hugging_facefield of typecommon.v2.HuggingFaceto theListTaskEntriesRequestmessage in bothpkg/apis/dfdaemon/v2/dfdaemon.protoandproto/dfdaemon.proto. [1] [2]ListTaskEntriesRequestinsrc/dfdaemon.v2.rsto include the new optionalhugging_facefield.Validation logic
pkg/apis/dfdaemon/v2/dfdaemon.pb.validate.goto validate the embeddedHuggingFacemessage if present.Version bump
Cargo.tomlfrom2.2.18to2.2.19to reflect the new feature addition.Related Issue
Motivation and Context