fix(useElementIds): improve fix for webpack analyzer#1677
Merged
silviuaavram merged 1 commit intomasterfrom Feb 19, 2026
Merged
fix(useElementIds): improve fix for webpack analyzer#1677silviuaavram merged 1 commit intomasterfrom
silviuaavram merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a webpack bundler issue where static analysis fails when building downshift with React 16/17 because it tries to resolve React.useId() which doesn't exist in those versions. The previous fix using bracket notation (React['useId']) apparently didn't work, so this PR proposes spreading the React object and accessing useId from the copy.
Changes:
- Replace bracket notation access to
React.useIdwith property access on a spread copy of the React object - Apply this pattern consistently across both
useElementIdsimplementations (dropdown and tag group utilities)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/hooks/utils.dropdown/useElementIds.ts | Replace React['useId'] with SafeReact.useId where SafeReact = {...React} |
| src/hooks/useTagGroup/utils/useElementIds.ts | Replace React['useId'] with SafeReact.useId where SafeReact = {...React} |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 9.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Previous fix did not work. This one should.
Why
Fixes #1674
How
Check #1674 (comment)
Changes
Checklist