generate_man: Prevent sibling node loss in man page generation#1436
Merged
cmouse merged 1 commit intodovecot:mainfrom Mar 2, 2026
Merged
generate_man: Prevent sibling node loss in man page generation#1436cmouse merged 1 commit intodovecot:mainfrom
cmouse merged 1 commit intodovecot:mainfrom
Conversation
slusarz
force-pushed
the
manpage_sibling_loss
branch
from
deb813a to
ef7468c
Compare
Parent's children array was being replaced entirely with the processed nodes of a single child, causing all sibling nodes to be discarded. Use `splice` to insert the processed nodes into the parent's children array in place, preserving siblings. Example diff (doveadm-who.1): < Global doveadm(1) --- > Global doveadm(1) \fIoptions\fR: 28c28 < Do not read any config file, just use defaults. The \fBdovecot_storage_version\fR setting defaults to the latest version, but can be overridden with --- > Do not read any config file, just use defaults. The \fBdovecot_storage_version\fR setting defaults to the latest version, but can be overridden with \fB-o\fR. 150c150 < By default doveadm(1) will use the socket --- > By default doveadm(1) will use the socket \fI/rundir/anvil\fR. The socket may be located in another directory, when the default \fIbase_dir\fR setting was overridden in \fI/etc/dovecot/dovecot.conf\fR.
cmouse
force-pushed
the
manpage_sibling_loss
branch
from
ef7468c to
579bcf6
Compare
cmouse
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent's children array was being replaced entirely with the processed nodes of a single child, causing all sibling nodes to be discarded.
Use
spliceto insert the processed nodes into the parent's children array in place, preserving siblings.Example diff (doveadm-who.1):
< Global doveadm(1)