Normalize enum names to lowercase in graphminimalpermissionsplugin schema#1524
Open
waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
Open
Normalize enum names to lowercase in graphminimalpermissionsplugin schema#1524waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JSON schemas for GraphMinimalPermissionsPlugin across multiple versioned schema folders to use lowercase enum values for the type setting, aligning the schema with the lowercase values used in configuration samples and (likely) runtime enum serialization conventions.
Changes:
- Changed
typeenum values from"Delegated"/"Application"to"delegated"/"application"in multiple schema versions. - Updated the
typeproperty description (where present) to reference lowercase values and default.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/v2.1.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v2.0.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.3.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.2.1/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.2.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.1.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.0.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.2/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.1/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.28.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.27.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.26.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values (no description in this schema version). |
| schemas/v0.25.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values (no description in this schema version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.