Fix GZip decompression when server transparently decompresses .gz files#1546
Open
alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
Open
Fix GZip decompression when server transparently decompresses .gz files#1546alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
Conversation
Check for GZIP magic bytes (0x1F, 0x8B) before attempting decompression. If the file is not actually gzip-compressed (e.g., the HTTP server or CDN transparently decompressed it during transfer), copy it as-is instead of throwing a GZipException. Fixes TestMNISTDownload failure: GZipException: Error GZIP header, first magic byte doesn't match Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for GZIP magic bytes (0x1F, 0x8B) before attempting decompression. If the file is not actually gzip-compressed (e.g., the HTTP server or CDN transparently decompressed it during transfer), copy it as-is instead of throwing a GZipException.
Fixes TestMNISTDownload failure:
GZipException: Error GZIP header, first magic byte doesn't match