Add user defined callback to be called on every shell execution#13
Open
igcybers wants to merge 2 commits intodjk2:masterfrom
Open
Add user defined callback to be called on every shell execution#13igcybers wants to merge 2 commits intodjk2:masterfrom
igcybers wants to merge 2 commits intodjk2:masterfrom
Conversation
djk2
requested changes
Oct 2, 2024
Owner
djk2
left a comment
djk2
left a comment
There was a problem hiding this comment.
Hi
Great thanks for extension of my lib.
What you prepared look good.
Nice idea to add callback - it could be very handy.
I have small request, if you could:
- add info to CHANGELOG.md
- upgrade version from VERSION = (2, 0, 1) =>VERSION = (2, 1, 0)
| ctx['auto_import'] = str(self.runner.importer) | ||
| return ctx | ||
|
|
||
| def call_callback(self, request, response, code) -> None: |
Owner
There was a problem hiding this comment.
If you could add some docstring will be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a user defined callback option which can be defined in settings.
This function will be called after every execution.
It helps with audit, e.g. saving all users executions into a database.