Conversation
rprospero
force-pushed
the
parameter_context
branch
from
a8558cb to
a2355ff
Compare
trisyoungs
approved these changes
Mar 20, 2026
src/classes/speciesSite.h
Outdated
| void deserialise(const SerialisedValue &node, CoreData &coreData) override; | ||
| }; | ||
|
|
||
| class Configuration; |
Member
There was a problem hiding this comment.
Perhaps move this up so its with the other fwd decs above?
src/nodes/parameter.h
Outdated
| throw(std::runtime_error(std::format("ParameterBase::get() failed to cast, name = {}.\n", name_))); | ||
| return cast->getData(); | ||
| } | ||
| // Get the parameter's value |
Member
There was a problem hiding this comment.
Suggested change
| // Get the parameter's value | |
| // Get the parameter's context |
src/nodes/parameter.h
Outdated
| protected: | ||
| // Reference to target data | ||
| DataClass &data_; | ||
| // Reference to target data |
Member
There was a problem hiding this comment.
Suggested change
| // Reference to target data | |
| // Context for target data |
rprospero
force-pushed
the
parameter_context
branch
from
a2355ff to
7184701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows types to define a context type. Declaring the parameter then requires that the context be passed in, if and only if there is a context.
I went with
std::monostatefor two reasons. First, it's the "official" type of empty data. As such, it includes such niceties as default and copy constructors. Secondly, as the official empty data type, it will take up zero bytes the moment that that is possible. It also gives the compiler the best opportunity to optimise out the context call in the parameter.