feat(prepare-commit-msg): Continue creating a commit even when an AI provider error occurs#527
Open
gidoichi wants to merge 2 commits intodi-sukharev:masterfrom
Open
feat(prepare-commit-msg): Continue creating a commit even when an AI provider error occurs#527gidoichi wants to merge 2 commits intodi-sukharev:masterfrom
gidoichi wants to merge 2 commits intodi-sukharev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
I encountered an issue when using the prepare-commit-msg hook to automatically generate commit messages. When an API call to the AI provider fails, the prepare-commit-msg hook also fails, and a commit cannot be created unless the hook is disabled. Such API failures can occur due to network issues or other temporary problems.
It is annoying to have to run
oco hook unset; git commit; oco hook setevery time to work around this issue.What has changed
commitMessagePromisesloop previously prevented errors from being caught; is has been replaced withPromise.allinstead.How does this work
When a commit is created during a network issue, the following message is displayed in your
$EDITOR: