fix: improve dark mode color contrast for WCAG 2.1 compliance (#449)#450
Open
Biswas-Samrat wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Open
fix: improve dark mode color contrast for WCAG 2.1 compliance (#449)#450Biswas-Samrat wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Biswas-Samrat wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Conversation
vbakke
reviewed
Jan 5, 2026
Collaborator
vbakke
left a comment
There was a problem hiding this comment.
Sorry, I cannot approve this @Biswas-Samrat.
- The original level-1 format might not follow best format practice, but is way easier to maintain than the proper auto format
- Suggested colors are using hard coded colors and CSS where not needed, and using
!important - It is hard to distinguish
selectableandhighlightedcolors in Teams view. This distinction is much more important than the visual clue between theslecteableand the grey background - The guid in not an important information, and does not need to be highlighted. A low, but acceptable contract is preferred
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #449 by updating the color palette in Dark Mode to ensure all text elements meet the WCAG 2.1 standard (minimum contrast ratio of 4.5:1)
Closes #449