Adding OhMyZsh-Theme Option to common-utils feature #1564
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Add ohMyZshTheme configuration option to common-utils
Author
|
@microsoft-github-policy-service agree |
Kaniska244
suggested changes
Feb 10, 2026
Contributor
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @the78mole
Thank you for the contribution. Would you kindly do a minor common-utils feature version bump for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for customizing the Oh My Zsh theme during installation in the
common-utilsfeature. The main changes include introducing a newohMyZshThemeoption, updating scripts to handle this option safely, and adding tests to verify theme customization.Feature: Oh My Zsh Theme Customization
ohMyZshThemeoption todevcontainer-feature.json, allowing users to specify the Oh My Zsh theme (default:devcontainers).README.mdto document the newohMyZshThemeoption and its usage.Implementation: Script Updates
install.shandmain.shto accept and use theOH_MY_ZSH_THEMEenvironment variable, defaulting todevcontainersif not specified. [1] [2]main.shto validate the theme name and update.zshrcaccordingly, falling back to the default if the provided name is invalid.Testing: Custom Theme Scenario
custom-zsh-theme.shto verify that the specified theme is applied and Oh My Zsh is installed.scenarios.jsonto include a scenario for testing custom theme installation with thefinotheme.