fix(ethers-v6): correctly type event listener#884
Open
pocin wants to merge 1 commit intodethcrypto:masterfrom
Open
fix(ethers-v6): correctly type event listener#884pocin wants to merge 1 commit intodethcrypto:masterfrom
pocin wants to merge 1 commit intodethcrypto:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #867
Not sure about the broader implications of this, but when i made this change to the generated file it correctly types the last event listener arg so one can do
seems to be working fine in my script so far