This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Open
Conversation
This change decouples the metrics collection and scraping, and allows custom scrapers. The default scraper stays the osiris one, using the auto-injected sidecar container. And we introduce a new scraper, using the prometheus format. It doesn't require the osiris proxy, and instead scrap metrics from a application-provided prometheus-compliant endpoint. see deislabs#48 for more details
vbehar
requested review from
jeremyrickard,
krancour and
yaron2
as code owners
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
===========================================
- Coverage 59.09% 37.33% -21.76%
===========================================
Files 11 17 +6
Lines 638 1192 +554
===========================================
+ Hits 377 445 +68
- Misses 232 716 +484
- Partials 29 31 +2
Continue to review full report at Codecov.
|
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change decouples the metrics collection and scraping, and allows custom scrapers.
The default scraper stays the osiris one, using the auto-injected sidecar container.
And we introduce a new scraper, using the prometheus format. It doesn't require the osiris proxy,
and instead scrap metrics from a application-provided prometheus-compliant endpoint.
see #48 for more details