Skip to content

Borrow lookup parameters #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduan merged 1 commit into from
Feb 6, 2026
Merged

Borrow lookup parameters #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions Sources/TOMLDecoder/Parsing/Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ private func makeString(bytes: UnsafeBufferPointer<UInt8>, range: Range<Int>) ->

extension Parser {
@inline(__always)
func matchKeyValue(in indices: [Int], key: String, keyHash: Int) -> Int? {
func matchKeyValue(in indices: borrowing [Int], key: borrowing String, keyHash: Int) -> Int? {
keyValues.withUnsafeBufferPointer { keyValueBuffer in
guard let keyValueBase = keyValueBuffer.baseAddress else {
return nil
Expand All @@ -1906,7 +1906,7 @@ extension Parser {
}

@inline(__always)
func matchKeyArray(in indices: [Int], key: String, keyHash: Int) -> Int? {
func matchKeyArray(in indices: borrowing [Int], key: borrowing String, keyHash: Int) -> Int? {
keyArrays.withUnsafeBufferPointer { keyArrayBuffer in
guard let keyArrayBase = keyArrayBuffer.baseAddress else {
return nil
Expand All @@ -1930,7 +1930,7 @@ extension Parser {
}

@inline(__always)
func matchKeyTable(in indices: [Int], key: String, keyHash: Int) -> Int? {
func matchKeyTable(in indices: borrowing [Int], key: borrowing String, keyHash: Int) -> Int? {
keyTables.withUnsafeBufferPointer { keyTableBuffer in
guard let keyTableBase = keyTableBuffer.baseAddress else {
return nil
Expand All @@ -1953,51 +1953,53 @@ extension Parser {
}
}

func tableValue(tableIndex: Int, keyed: Bool, key: String, keyHash: Int) -> InternalTOMLTable.Value? {
@inline(__always)
func tableValue(
tableIndex: Int,
keyed: Bool,
key: borrowing String,
keyHash: Int
) -> InternalTOMLTable.Value? {
if keyed {
let keyValueIndices = keyTables[tableIndex].table.keyValues
if let keyValueIndex = matchKeyValue(in: keyValueIndices, key: key, keyHash: keyHash) {
if let keyValueIndex = matchKeyValue(in: keyTables[tableIndex].table.keyValues, key: key, keyHash: keyHash) {
return .keyValue(keyValueIndex)
}

let keyArrayIndices = keyTables[tableIndex].table.arrays
if let keyArrayIndex = matchKeyArray(in: keyArrayIndices, key: key, keyHash: keyHash) {
if let keyArrayIndex = matchKeyArray(in: keyTables[tableIndex].table.arrays, key: key, keyHash: keyHash) {
return .array(keyArrayIndex)
}

let keyTableIndices = keyTables[tableIndex].table.tables
if let keyTableIndex = matchKeyTable(in: keyTableIndices, key: key, keyHash: keyHash) {
if let keyTableIndex = matchKeyTable(in: keyTables[tableIndex].table.tables, key: key, keyHash: keyHash) {
return .table(keyTableIndex)
}
return nil
}

let keyValueIndices = tables[tableIndex].keyValues
if let keyValueIndex = matchKeyValue(in: keyValueIndices, key: key, keyHash: keyHash) {
if let keyValueIndex = matchKeyValue(in: tables[tableIndex].keyValues, key: key, keyHash: keyHash) {
return .keyValue(keyValueIndex)
}

let keyArrayIndices = tables[tableIndex].arrays
if let keyArrayIndex = matchKeyArray(in: keyArrayIndices, key: key, keyHash: keyHash) {
if let keyArrayIndex = matchKeyArray(in: tables[tableIndex].arrays, key: key, keyHash: keyHash) {
return .array(keyArrayIndex)
}

let keyTableIndices = tables[tableIndex].tables
if let keyTableIndex = matchKeyTable(in: keyTableIndices, key: key, keyHash: keyHash) {
if let keyTableIndex = matchKeyTable(in: tables[tableIndex].tables, key: key, keyHash: keyHash) {
return .table(keyTableIndex)
}

return nil
}

func lookupTable(in tableIndex: Int, keyed: Bool, key: String, keyHash: Int) -> Int? {
@inline(__always)
func lookupTable(in tableIndex: Int, keyed: Bool, key: borrowing String, keyHash: Int) -> Int? {
if keyed {
return matchKeyTable(in: keyTables[tableIndex].table.tables, key: key, keyHash: keyHash)
}
return matchKeyTable(in: tables[tableIndex].tables, key: key, keyHash: keyHash)
}

func lookupArray(in tableIndex: Int, keyed: Bool, key: String, keyHash: Int) -> Int? {
@inline(__always)
func lookupArray(in tableIndex: Int, keyed: Bool, key: borrowing String, keyHash: Int) -> Int? {
if keyed {
return matchKeyArray(in: keyTables[tableIndex].table.arrays, key: key, keyHash: keyHash)
}
Expand Down
Loading