Skip to content

Support sqlglot 28 and 29#1698

Open
rolandwalker wants to merge 1 commit intomainfrom
RW/support-sqlglot-28-and-29
Open

Support sqlglot 28 and 29#1698
rolandwalker wants to merge 1 commit intomainfrom
RW/support-sqlglot-28-and-29

Conversation

@rolandwalker
Copy link
Contributor

@rolandwalker rolandwalker commented Mar 11, 2026

Description

Fixes #1696

Confirmed locally that the test suite runs with sqlglot 28 and 29.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 11, 2026
@github-actions
Copy link

  1. Missing validation for the newly supported versions (pyproject.toml:17)
    • The PR widens sqlglot to >=27,<30 and claims support for 28/29, but no tests or CI matrix updates were added to exercise sqlglot==28.* and sqlglot==29.*.
    • Risk: compatibility regressions can ship unnoticed (especially around token/parsing APIs used in parseutils/hybrid_redirection).
    • Action: add at least two test jobs (or tox envs) that pin sqlglot==28.* and sqlglot==29.* and run the existing test suite (or a targeted parser/tokenization subset if runtime is a concern).

No direct security issues are introduced by this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for sqlglot 28?

1 participant