Skip to content

Ability to turn off the toolbar#1686

Merged
rolandwalker merged 1 commit intomainfrom
RW/ability-to-turn-off-toolbar
Mar 7, 2026
Merged

Ability to turn off the toolbar#1686
rolandwalker merged 1 commit intomainfrom
RW/ability-to-turn-off-toolbar

Conversation

@rolandwalker
Copy link
Contributor

Description

When the toolbar was made customizable, there was already a default toolbar. To be extra sure we were compatible with any myclirc in the world, the empty value for a toolbar format was made the same as the default toolbar.

This introduces a special value None which makes the toolbar disappear in the UI.

Motivation: the user may prefer the information in, for instance, a tmux window title, or the prompt. Or just a simpler UI.

xref #1684

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 7, 2026
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

  1. Missing regression tests for new toolbar=None behavior
    Change at main.py:1270 adds special handling to disable the toolbar, but the PR only updates config comments (test/myclirc:130) and adds no behavioral test coverage.
    Actionable: add tests that verify:
    • toolbar = None (and case variants like none) disables bottom_toolbar.
    • Empty toolbar (toolbar = '') still keeps default toolbar behavior.
    • Non-None custom toolbar strings still render as before.

No security concerns found in this diff.

Copy link
Contributor

@scottnemes scottnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified toolbar=None disables the toolbar

When the toolbar was made customizable, there was already a default
toolbar.  To be extra sure we were compatible with any myclirc in the
world, the empty value for a toolbar format was made the same as the
default toolbar.

This introduces a special value None which makes the toolbar disappear
in the UI.

Motivation: the user may prefer the information in, for instance, a
tmux window title, or the prompt.  Or just a simpler UI.
@rolandwalker rolandwalker force-pushed the RW/ability-to-turn-off-toolbar branch from 6352de2 to fe808a6 Compare March 7, 2026 23:54
@rolandwalker rolandwalker merged commit 7da5cc0 into main Mar 7, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/ability-to-turn-off-toolbar branch March 7, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants