Remove the Menu bar and Add Pointer Cursors#76
Closed
kevwilliams wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
|
might need a rebase i think |
kevwilliams
changed the base branch from
main
to
native-window-and-ui-updates
Author
|
Yea I forgot I started with Matt's native-window branch - changed base. That could be merged first and this could be merged after if thats cleaner. |
Contributor
|
@kevwilliams just merged Matts branch |
kevwilliams
changed the base branch from
native-window-and-ui-updates
to
main
Contributor
|
I had made a conscious decision not to use Happy to stick them in if that's the consensus though. Looks like we need to make some more platform specific changes to the UI - that bar with the Datum logo looks odd on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hides the transparent menubar and also adds pointer cursors on the toggle switch, buttons, and clickable dropdown triggers for visible feedback on clickable things in the proxies list and dialogs.
This is what the menubar looks like on wayland/linux desktop, you can see its transparent and kinda fun looking so I hid it.
Adding cursor-pointer on toggle and buttons:
