Skip to content

Conversation

@xdustinface
Copy link
Collaborator

time::sleep(MAINTENANCE_INTERVAL) creates a fresh future on each tokio::select! loop iteration. Since time::interval().tick() fires immediately on the first poll, the DNS branch completes first and the maintenance sleep is dropped before awaiting. With MAINTENANCE_INTERVAL and DNS_DISCOVERY_DELAY both at 10 seconds, maintenance_tick will never execute in non-exclusive mode.

Also delay the first DNS interval tick by DNS_DISCOVERY_DELAY since we don't need to run it initially.

`time::sleep(MAINTENANCE_INTERVAL)` creates a fresh future on each `tokio::select!` loop iteration. Since `time::interval().tick()` fires immediately on the first poll, the DNS branch completes first and the maintenance sleep is dropped before awaiting. With `MAINTENANCE_INTERVAL` and `DNS_DISCOVERY_DELAY` both at 10 seconds, maintenance_tick will never execute in non-exclusive mode.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Warning

Rate limit exceeded

@xdustinface has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/network-maintainance-interval

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface reopened this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant