-
Notifications
You must be signed in to change notification settings - Fork 45
chore(swift-sdk): clean up core transactions, wallet, balance, acccounts, etc in swift sdk #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/iOSSupport
Are you sure you want to change the base?
Conversation
…t functionalities
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "e8fdb3cd8dce4b9d023b88df47525db1dc7c8434913c870abef7f080f5801d7d"
)Xcode manual integration:
|
2aaca9d to
d37de8f
Compare
Balances where not being shown correctly and the main issue was the enormous amount of logic, the underlying Rust lib contains the logic and the sdk only needs to wrap it, dropped all logic that was unnecessary and added one method to CoreWalletManager wrapper:
This follows the same pattern the transactions follow, asking directly the ffi for the balance.
Note that this PR is a cleanup, I drop unused stuff and logic layers that are not useful, the PR fixes the mentioned issue, and a couple more found while cleaning, like wallets being persisted twice, SPVclient reference being hold somewhere preventing it from de-initializing, wallet crashes after delete and maybe more
Checklist:
For repository code-owners and collaborators only