Harden data integrity coverage for backup, import/export, and core journal flows#84
Merged
danielchalmers merged 2 commits intomainfrom Mar 17, 2026
Merged
Harden data integrity coverage for backup, import/export, and core journal flows#84danielchalmers merged 2 commits intomainfrom
danielchalmers merged 2 commits intomainfrom
Conversation
…urnal flows This change strengthens regression protection around the app’s most data-sensitive behavior, with a focus on preventing silent data loss, bad restores, and incorrect “success” states. It adds high-value tests for: - backup/import/export workflows, including cancel and failure paths - archive round-trip relationship integrity - preference restore behavior and malformed persisted values - hot-path data generation and state propagation in core journal interactions - edge cases around medication defaults, welcome-note generation, and user-visible state updates It also tightens several existing tests that were weak or asserting the wrong contract, so the suite now better reflects the behavior we actually want to preserve. Behaviorally, this also fixes one real risk discovered during the audit: importing backed-up preferences no longer wipes unrelated user settings that were never part of the backup. Validation: - full test suite run completed successfully - result: 188 passed, 1 skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens test coverage around the app’s most sensitive user-data paths and tightens a number of existing tests so they better reflect the real contracts the app depends on.
What’s included:
Validation: