Skip to content

Enhance CI workflow for multi-platform Qt builds macOS Intel & ARM#979

Closed
alsyundawy wants to merge 1 commit intodail8859:masterfrom
alsyundawy:master
Closed

Enhance CI workflow for multi-platform Qt builds macOS Intel & ARM#979
alsyundawy wants to merge 1 commit intodail8859:masterfrom
alsyundawy:master

Conversation

@alsyundawy
Copy link

Enhance CI workflow for multi-platform Qt builds macOS Intel & ARM

Refactor GitHub Actions workflow to include detailed platform and version configurations for building with Qt. Added support for multiple OS and architecture combinations, improved artifact handling, and updated action versions.

working like charm but icon not showing

can you @dail8859 reviews ?

Enhance CI workflow for multi-platform Qt builds macOS Intel & ARM

Refactor GitHub Actions workflow to include detailed platform and version configurations for building with Qt. Added support for multiple OS and architecture combinations, improved artifact handling, and updated action versions.
@dail8859
Copy link
Owner

There are:

  • Too many changes
  • Changes that are seemingly not relevant due to no comments
  • Comments I cannot understand
  • Useless comments
  • Unclear requirements...what exactly is this solving? Cannot all macs run the current DMG file?
  • Lots of formatting changes on parts of the code that are not needed
  • Enhancements that are not desired (e.g. echo "DISTRIBUTION=Installer")
  • GitHub actions that are downgraded
  • Breaking changes (e.g github.repository == 'alsyundawy/NotepadNext')

For me to be able to review pull requests, they should be small, clear, concise, and focus on a single problem that is clearly defined. I'd rather have 4 small PRs to review than one big one that is hard to understand the changes.

Were these changes reviewed line by line? Or did AI just spit this out and a PR submitted after the GitHub actions passed?

@dail8859 dail8859 closed this Mar 12, 2026
@alsyundawy
Copy link
Author

alsyundawy commented Mar 13, 2026

on runner intel use macos-15-intel dan arm macos-latest, you can try

image

or check artifact on your repo fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants