Merge upstream PR #179 updates (Claude adapter + storage refactor)#4
Merge upstream PR #179 updates (Claude adapter + storage refactor)#4dafzthomas wants to merge 4 commits intomainfrom
Conversation
Merges latest commits from pingdotgg#179 including: - Storage refactor (composerDraftStore extracted resolveModelOptions) - setState pattern refactored in browser test fixtures - Upstream main merged in (terminal context, sidebar fixes, git text gen) - Button overflow fix Conflict resolution: - Keep Haven Code fork identity (Bedrock settings, enableCodexProvider, claude-haiku-4-5 as default git text gen model, Bedrock badge in picker) - Accept upstream refactors (draftsByThreadId variable pattern, resolveModelOptions callback, CSS improvements) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
size:XL
vouch:trusted
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25b28e3a9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!persisted || persisted.version !== COMPOSER_DRAFT_STORAGE_VERSION) { | ||
| return []; |
There was a problem hiding this comment.
This version gate returns an empty attachment set for any persisted draft blob not already on the current version, which bypasses migration in readPersistedAttachmentIdsFromStorage. In upgrade scenarios (e.g., users with older localStorage drafts containing image attachments), syncPersistedAttachments will treat all images as not persisted and can then overwrite local draft state with persistedAttachments: [], silently dropping previously saved attachments. The previous code path migrated old payloads before reading IDs, so this is a behavioral regression for existing user data.
Useful? React with 👍 / 👎.
3 participants
Summary
pingdotgg/t3code#179(codething/648ca884-claude)enableCodexProvider,claude-haiku-4-5default, Bedrock badge)Conflict Resolution
appSettings.tsChatView.tsxClaudeTraitsPicker.browser.tsxCodexTraitsPicker.browser.tsxCompactComposerControlsMenu.browser.tsxProviderModelPicker.tsxcomposerDraftStore.tsresolveModelOptions+ ourObject.freezemodel.tsclaude-haiku-4-5as default git text gen modelVerification
🤖 Generated with Claude Code