Add comprehensive test suites for all analyzer plugins#48
Merged
YusukeHirao merged 3 commits intomainfrom Mar 5, 2026
Merged
Conversation
Add index.spec.ts for analyze-axe, analyze-main-contents, analyze-markuplint, analyze-search, and analyze-textlint. External dependencies are mocked; DOM-dependent plugins use JSDOM. https://claude.ai/code/session_01ERi5hKHKWmJAfdkkxUGMbb
- analyze-axe: verify axe.configure with locale success/failure, assert color-contrast rule disabled in axe.run() - analyze-search: use hardcoded literals instead of expect.any(Number), prove scope restricts matches to 1, add attribute match and excluded attribute tests - analyze-markuplint: use toHaveBeenLastCalledWith to avoid stale mock history - analyze-textlint: verify TextlintKernelDescriptor receives merged rules with disabled rules excluded and overridden options - analyze-main-contents: add #content/.main fallback selector tests and DOM-order priority test https://claude.ai/code/session_01ERi5hKHKWmJAfdkkxUGMbb
Add TODO comment documenting the Content object key inconsistency between toHeader (uses item.search) and toArray (uses item.title). This causes report header keys to not match result keys when using Content objects. The test records this current (buggy) behavior. https://claude.ai/code/session_01ERi5hKHKWmJAfdkkxUGMbb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds complete test coverage for all five analyzer plugins in the
@nitpickerpackage. Each plugin now has a dedicated test suite covering core functionality, edge cases, and error handling.closes: #12
Key Changes
Test Files Added
Test Coverage Highlights
Notable Implementation Details
https://claude.ai/code/session_01ERi5hKHKWmJAfdkkxUGMbb