Skip to content

Add analyze plugins to CLI dependencies for npx resolution#45

Merged
YusukeHirao merged 3 commits intomainfrom
claude/fix-analyze-plugin-npx-aI90W
Mar 5, 2026
Merged

Add analyze plugins to CLI dependencies for npx resolution#45
YusukeHirao merged 3 commits intomainfrom
claude/fix-analyze-plugin-npx-aI90W

Conversation

@YusukeHirao
Copy link
Copy Markdown
Member

@YusukeHirao YusukeHirao commented Mar 5, 2026

Summary

Updated the CLI package to explicitly include all analyze plugins as direct dependencies, enabling proper module resolution when running commands via npx.

closes: #34

Key Changes

  • Added all 6 analyze plugins (@nitpicker/analyze-*) to @nitpicker/cli dependencies:

    • @nitpicker/analyze-axe
    • @nitpicker/analyze-lighthouse
    • @nitpicker/analyze-main-contents
    • @nitpicker/analyze-markuplint
    • @nitpicker/analyze-search
    • @nitpicker/analyze-textlint
  • Updated architecture documentation (ARCHITECTURE.md and CLAUDE.md) to clarify:

    • The dependency relationship between CLI and analyze plugins
    • That CLI must include all analyze plugins in dependencies for npx execution
    • How @nitpicker/core dynamically imports plugins at runtime

Implementation Details

The CLI now acts as a dependency aggregator for all analyze plugins. This ensures that when users run npx @nitpicker/cli analyze, the dynamic import() calls in @nitpicker/core can properly resolve plugin modules without requiring users to install them separately. The documentation includes a note for future maintainers to add new analyze plugins to this list when they are created.

https://claude.ai/code/session_013sn9ycemnanzocpDRtT689

claude added 3 commits March 5, 2026 09:29
When running via `npx @nitpicker/cli analyze`, the dynamic `import()`
calls in `@nitpicker/core` fail with ERR_MODULE_NOT_FOUND because the
analyze plugin packages are not in the CLI's dependency tree. Add all
six standard analyze plugins as direct dependencies of `@nitpicker/cli`.

Closes #34

https://claude.ai/code/session_013sn9ycemnanzocpDRtT689
…encies

The CLI now directly depends on analyze-* plugins for npx module resolution.
Update dependency graphs in ARCHITECTURE.md and CLAUDE.md to reflect this,
and add a note about maintaining CLI dependencies when adding new plugins.

https://claude.ai/code/session_013sn9ycemnanzocpDRtT689
… plugin note

- Add @d-zero/dealer to the dependency graph (was missing)
- Add note about CLI depending on analyze-* plugins for npx module resolution
- Add explanation to @nitpicker/cli section about bundled plugin dependencies

https://claude.ai/code/session_013sn9ycemnanzocpDRtT689
@YusukeHirao YusukeHirao merged commit 7ab88d1 into main Mar 5, 2026
3 checks passed
@YusukeHirao YusukeHirao deleted the claude/fix-analyze-plugin-npx-aI90W branch March 5, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug(cli): analyze プラグインが npx 実行時に見つからない

2 participants