Draft
Conversation
When two ambiguous delimiters (like single quotes) matched, the stack truncation destroyed all entries above the match — including unrelated delimiter types (backticks) pushed between the matched pair. Use splice instead of truncation for ambiguous delimiters to preserve unrelated stack entries.
Member
|
This implementation still isn't correct. The original implementation was on purpose. We don't support overlapping scopes. Nested scopes yes, but not overlapping. What we want is some logic to determine that the first delimiter in this example is the one that shouldn't be used. The desired result is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3109.
getSurroundingPairOccurrences, the stack truncation (openingDelimitersStack.length = index) destroyed all stack entries above the match — including unrelated delimiter types (backticks) pushed between the matched pairsplice(index, 1)for ambiguous (side === "unknown") delimiters to remove only the matched entry, preserving other delimiter types on the stackside === "right") still truncate the stack to enforce proper nestingTest plan
changeInsideMixedQuotesrecorded fixture reproducing the exact scenario from"inside"broken in particular configuration of quotes #3109surroundingPair/textualtests passpnpm run compile)