Replace flynt with ruff FLY rules and bump pre-commit hooks#3169
Open
Replace flynt with ruff FLY rules and bump pre-commit hooks#3169
Conversation
- Remove flynt hook; ruff's FLY002 + existing UP031/UP032 rules cover the same f-string conversions - Bump hook versions: pre-commit-hooks v4.4.0→v6.0.0, Lucas-C v1.5.1→v1.5.6, ruff v0.4.1→v0.15.1 - Bump minimum_pre_commit_version to 3.2.0 (required by pre-commit-hooks v6) - Add FLY to ruff select, add UP045 to ignore (same Talon runtime issue as UP007; see talonvoice/talon#634) - Apply ruff autofixes: SIM905 in default_vocabulary.py, C420 in destinations.py Closes #2308, closes #1885
auscompgeek
reviewed
Feb 14, 2026
| # https://github.com/talonhub/community/blob/9acb6c9659bb0c9b794a7b7126d025603b4ed726/core/keys/keys.py#L10 | ||
| initial_default_alphabet = "air bat cap drum each fine gust harp sit jury crunch look made near odd pit quench red sun trap urge vest whale plex yank zip".split() | ||
| initial_default_alphabet = [ | ||
| "air", |
Member
There was a problem hiding this comment.
This was intentionally written in community with .split() to reduce the syntactic noise so those new to Python would be more comfortable, right? I'm wondering if we should exclude this rule
Member
There was a problem hiding this comment.
No idea about the original intent in community, but the alphabet has been stable for so long that I think it's fine to do this change here in Cursorless without any problems with future updates.
AndreasArvidsson
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flyntpre-commit hook — ruff'sFLY002rule (plus existingUP031/UP032) covers the same f-string conversionspre-commit-hooksv4.4.0→v6.0.0,Lucas-Cv1.5.1→v1.5.6,ruffv0.4.1→v0.15.1minimum_pre_commit_versionto 3.2.0 (required bypre-commit-hooksv6)FLYto ruff lint select; addUP045to ignore list (same Talon runtime issue asUP007— see TalonScript TypeError when usingX | Y-style union types for action parameter type hints talonvoice/talon#634, tracked in Re-enableUP007#2151)SIM905indefault_vocabulary.py,C420indestinations.pyCloses #2308, closes #1885
Test plan
ruff checkpasses cleanruff format --checkpasses cleanpnpm run compilepasses