Skip to content

Equipment scraper fix + workflow pruning command fix#228

Open
JoshD94 wants to merge 2 commits intomasterfrom
josh-equipmentscraperfix
Open

Equipment scraper fix + workflow pruning command fix#228
JoshD94 wants to merge 2 commits intomasterfrom
josh-equipmentscraperfix

Conversation

@JoshD94
Copy link
Contributor

@JoshD94 JoshD94 commented Mar 6, 2026

Overview

Equipment scraper had a bug, fixed the scraper.
Workflow pruning command doesn't prune dangling/unused images, fixed command.

Changes Made

  • The scraper bug was because Noyes' equipment table changed a little bit, used to depend on even rows. Now scrapes based off th and td tags.
  • Workflow was previously changed to 'docker system prune -f', this doesn't prune dangling/unused images that are not referenced. Changed to 'docker images prune -a' and pipeline a yes to confirm. This will prune dangling/unused images, which are created everytime we deploy because we pull a newer version of the image.

Test Coverage

Tested scraper locally. Tested pruning on dev server.

Copy link
Contributor

@cejiogu cejiogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants