This repository was archived by the owner on Jun 3, 2019. It is now read-only.
Use babel 7 and development property on react-preset#574
Open
Aetherall wants to merge 4 commits intoctrlplusb:nextfrom
Open
Use babel 7 and development property on react-preset#574Aetherall wants to merge 4 commits intoctrlplusb:nextfrom
Aetherall wants to merge 4 commits intoctrlplusb:nextfrom
Conversation
Owner
|
Awesome, thanks for the contribution! 🤘 |
Contributor
|
@ctrlplusb Is this and the |
|
@oyeanuj Waiting for the same! @ctrlplusb Any potential date? |
|
I can't wait for the merge. What I remember is @ctrlplusb was waiting for a new version of react-tree-walker. cc @oyeanuj |
Contributor
|
@Aetherall Do you have an updated version of this PR? And how has Babel 7 been working for you? |
Author
|
@oyeanuj Babel 7 has been working exactly like Babel 6, You can make this step serenely |
hiranivipul
approved these changes
Aug 2, 2018
Contributor
|
@ctrlplusb Is this good to merge in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
Thanks for this awesome project !
Just a small PR to use babel 7 :) 🎉
Also, removed 'transform-react-jsx-xxx' plugins,
since they are used when using the development property on preset-react