Skip to content

WIP #331 - Add some suggested options #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigfowler merged 4 commits into from
Mar 21, 2026
Merged

WIP #331 - Add some suggested options #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c6e16a
WIP #331 - Add some suggested options
craigfowler Mar 19, 2026
e69211c
Switch on verbose logging for #331
craigfowler Mar 20, 2026
7f92225
WIP #331 - Use upgraded webdriver factory
craigfowler Mar 21, 2026
4dd8572
Another attempt to make tests reliable
craigfowler Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnetCi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
PullRequestParam: ${{ github.event_name == 'pull_request' && format('/d:sonar.pullrequest.key={0}', github.event.number) || '' }}
DISPLAY: :99
# Change selected factory to VerboseChrome to debug Chrome-related issues
WebDriverFactory__SelectedConfiguration: DefaultChrome
WebDriverFactory__SelectedConfiguration: CiHeadlessChrome

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion CSF.Screenplay.Selenium/CSF.Screenplay.Selenium.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="Microsoft.Bcl.HashCode" Version="1.0.0" Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == '$(DotNetFrameworkLegacy)'" />
<PackageReference Include="Selenium.WebDriver" Version="4.0.0" />
<PackageReference Include="Selenium.Support" Version="4.0.0" />
<PackageReference Include="CSF.Extensions.WebDriver" Version="2.0.0-5.beta" />
<PackageReference Include="CSF.Extensions.WebDriver" Version="2.0.0-6.beta" />
<PackageReference Include="CSF.Specifications" Version="2.0.0" />
</ItemGroup>

Expand Down
12 changes: 12 additions & 0 deletions Tests/CSF.Screenplay.Selenium.Tests/CiChromeOptionsCustomizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using CSF.Extensions.WebDriver.Factories;
using OpenQA.Selenium.Chrome;

namespace CSF.Screenplay.Selenium;

public class CiChromeOptionsCustomizer : ICustomizesOptions<ChromeOptions>
{
public void CustomizeOptions(ChromeOptions options)
{
options.AddArguments("--disable-dev-shm-usage", "--headless", "--no-sandbox", "--disable-gpu", "--window-size=1280,1024");
}
}
4 changes: 4 additions & 0 deletions Tests/CSF.Screenplay.Selenium.Tests/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
"DriverType": "ChromeDriver",
"DriverFactoryType": "CSF.Screenplay.Selenium.VerboseChromeDriverFactory, CSF.Screenplay.Selenium.Tests"
},
"CiHeadlessChrome": {
"DriverType": "ChromeDriver",
"OptionsCustomizerType ": "CSF.Screenplay.Selenium.CiChromeOptionsCustomizer, CSF.Screenplay.Selenium.Tests"
},
"BrowserStack": {
"DriverType": "RemoteWebDriver",
"DriverFactoryType": "CSF.Screenplay.Selenium.BrowserStack.BrowserStackDriverFactory, CSF.Screenplay.Selenium.Tests"
Expand Down
Loading