fix: raise value error on no file support#4640
Open
greysonlalonde wants to merge 3 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new
ValueErrorfor calls that includefileson models without multimodal support, which can break previously-silent workflows. Model capability detection is also expanded (Claude 4 variants), so behavior may change for some model strings.Overview
File attachments now fail fast on unsupported models. When
crewai_filesis installed,_process_message_files/_aprocess_message_files(in bothLLMandBaseLLM) now raise a clearValueErrorif any message includesfilesbut the selected model doesn’t support multimodal input, instead of silently ignoring file inputs.Expanded multimodal model matching. Multimodal detection was updated to recognize additional Claude 4 model name variants in the LiteLLM path, the Anthropic native provider, and Bedrock model prefixes.
Written by Cursor Bugbot for commit 0a6f237. This will update automatically on new commits. Configure here.