Skip to content

chore: implement security best practices (Docker hardening, configurable CORS, sanitized logs) #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: implement security best practices (Docker hardening, configurable CORS, sanitized logs) #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,22 @@ RUN apt-get update \
libpq5 \
&& rm -rf /var/lib/apt/lists/*

# Create a non-root user
RUN groupadd -r appuser && useradd -r -g appuser appuser

# Set the working directory
WORKDIR /app

# Copy virtual environment from builder
COPY --from=builder /app/.venv /app/.venv

# Copy application code
COPY --from=builder /app/intentkit /app/intentkit
COPY --from=builder /app/app /app/app
COPY --from=builder /app/scripts /app/scripts
# Copy application code with correct ownership
COPY --from=builder --chown=appuser:appuser /app/intentkit /app/intentkit
COPY --from=builder --chown=appuser:appuser /app/app /app/app
COPY --from=builder --chown=appuser:appuser /app/scripts /app/scripts

# Switch to non-root user
USER appuser

ARG RELEASE=local
ENV RELEASE=$RELEASE
Expand Down
4 changes: 2 additions & 2 deletions app/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _load_agent_api_docs() -> str:
# Add CORS middleware to the Agent API sub-application
_ = agent_app.add_middleware(
CORSMiddleware,
allow_origins=["*"], # Allows all origins
allow_origins=config.cors_allow_origins, # Allows configured origins
allow_methods=["*"], # Allows all methods
allow_headers=["*"], # Allows all headers
)
Expand Down Expand Up @@ -187,7 +187,7 @@ async def lifespan(app: FastAPI):
# Add CORS middleware
_ = app.add_middleware(
CORSMiddleware,
allow_origins=["*"], # Allows all origins
allow_origins=config.cors_allow_origins, # Allows configured origins
allow_methods=["*"], # Allows all methods
allow_headers=["*"], # Allows all headers
)
Expand Down
5 changes: 5 additions & 0 deletions intentkit/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ def __init__(self) -> None:
self.open_api_base_url: str = self.load(
"OPEN_API_BASE_URL", "http://localhost:8000"
)
# CORS
cors_origins_raw = self.load("CORS_ALLOW_ORIGINS", "*")
self.cors_allow_origins: list[str] = [
o.strip() for o in cors_origins_raw.split(",") if o.strip()
]
# CDP SDK Configuration
self.cdp_api_key_id: str | None = self.load("CDP_API_KEY_ID")
self.cdp_api_key_secret: str | None = self.load("CDP_API_KEY_SECRET")
Expand Down
17 changes: 6 additions & 11 deletions intentkit/wallets/privy_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,9 @@ async def create_wallet(

if response.status_code not in (200, 201):
logger.info(
"Privy create_wallet response: status=%s auth_sig_count=%s body=%s",
"Privy create_wallet response: status=%s auth_sig_count=%s",
response.status_code,
signature_count,
response.text,
)

raise IntentKitAPIError(
Expand Down Expand Up @@ -351,12 +350,11 @@ async def sign_message(self, wallet_id: str, message: str) -> str:

if response.status_code not in (200, 201):
logger.info(
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s body=%s",
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s",
wallet_id,
payload.get("method"),
response.status_code,
signature_count,
response.text,
)

raise IntentKitAPIError(
Expand Down Expand Up @@ -428,12 +426,11 @@ async def sign_hash(self, wallet_id: str, hash_bytes: bytes) -> str:

if response.status_code not in (200, 201):
logger.info(
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s body=%s",
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s",
wallet_id,
payload.get("method"),
response.status_code,
signature_count,
response.text,
)

raise IntentKitAPIError(
Expand Down Expand Up @@ -497,12 +494,11 @@ async def sign_typed_data(self, wallet_id: str, typed_data: dict[str, Any]) -> s

if response.status_code not in (200, 201):
logger.info(
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s body=%s",
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s",
wallet_id,
payload.get("method"),
response.status_code,
signature_count,
response.text,
)

raise IntentKitAPIError(
Expand Down Expand Up @@ -580,18 +576,17 @@ async def send_transaction(

if response.status_code not in (200, 201):
logger.info(
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s body=%s",
"Privy rpc response: wallet_id=%s method=%s status=%s auth_sig_count=%s",
wallet_id,
payload.get("method"),
response.status_code,
signature_count,
response.text,
)

raise IntentKitAPIError(
response.status_code,
"PrivyAPIError",
f"Failed to send transaction: {response.text}",
"Failed to send transaction with Privy wallet",
)

data_response = response.json()
Expand Down