Conversation
- Bump node to version 24, but continue (deprecated) support for version 18. - Run Node 18, 22, and 24 in CI
Override serialize-javascript (high severity). Audit still reports elliptic (low severity) but there is no patch available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 52 52
Lines 4607 4607
Branches 1297 1297
=======================================
Hits 4035 4035
Misses 359 359
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hossenlopp
approved these changes
Mar 20, 2026
Contributor
hossenlopp
left a comment
There was a problem hiding this comment.
Looks good! Works fine in fqm-execution as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Ignore Failed CI for npm audit. There is currently no available resolution.
This pull request updates
cql-executionto prefer Node 24 for development and testing. It does this via the following changes:.tool-versionsfile@types/nodeto^24.12.0in thepackage.jsonfile.github/workflows/ci-workflow.ymlfile to use Node 24 for npm audit, check cql4browsers, lint, and prettier; and uses a matrix of Node 18, 22, and 24 for running testsREADME.mdto express preference for Node 24 and deprecation of Node 18It also updates outdated dependencies and fixes npm audit issues as possible (with the exception of
elliptic, which has no fix available).To test, use Node 24 (via ASDF or any other means) to
npm install,npm run build:all, andnpm run test:plus. All tests should pass and there should not be any changed files.Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: @hossenlopp