Skip to content

Prefer Node 24.x#358

Merged
cmoesel merged 4 commits intomasterfrom
node24
Mar 20, 2026
Merged

Prefer Node 24.x#358
cmoesel merged 4 commits intomasterfrom
node24

Conversation

@cmoesel
Copy link
Member

@cmoesel cmoesel commented Mar 19, 2026

NOTE: Ignore Failed CI for npm audit. There is currently no available resolution.

This pull request updates cql-execution to prefer Node 24 for development and testing. It does this via the following changes:

  • Adds nodejs 24.14.0 to the ASDF .tool-versions file
  • Updates @types/node to ^24.12.0 in the package.json file
  • Updates the .github/workflows/ci-workflow.yml file to use Node 24 for npm audit, check cql4browsers, lint, and prettier; and uses a matrix of Node 18, 22, and 24 for running tests
  • Updates the README.md to express preference for Node 24 and deprecation of Node 18

It also updates outdated dependencies and fixes npm audit issues as possible (with the exception of elliptic, which has no fix available).

To test, use Node 24 (via ASDF or any other means) to npm install, npm run build:all, and npm run test:plus. All tests should pass and there should not be any changed files.

Submitter:

  • This pull request describes why these changes were made
  • [n/a] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • [n/a] Tests are included and test edge cases
  • Tests have been run locally and pass
  • [n/a] Code coverage has not gone down and all code touched or added is covered.
  • Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
  • All dependent libraries are appropriately updated or have a corresponding PR related to this change
  • cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name: @hossenlopp

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

cmoesel added 4 commits March 19, 2026 11:18
- Bump node to version 24, but continue (deprecated) support for version 18.
- Run Node 18, 22, and 24 in CI
Override serialize-javascript (high severity). Audit still reports elliptic (low severity) but there is no patch available.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.58%. Comparing base (1545ebb) to head (83ac74e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          52       52           
  Lines        4607     4607           
  Branches     1297     1297           
=======================================
  Hits         4035     4035           
  Misses        359      359           
  Partials      213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Works fine in fqm-execution as expected.

@cmoesel cmoesel merged commit 2dd80cf into master Mar 20, 2026
10 of 12 checks passed
@cmoesel cmoesel deleted the node24 branch March 20, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants