Open
Conversation
nickolaym
reviewed
Oct 14, 2023
just_simple_test.cpp
Outdated
| std::vector<int> xs; | ||
| xs.reserve(100500); | ||
| xs.clear(); | ||
| EXPECT_CMP(xs.capacity(), ==, 0) << " ahaha ? ahaha!"; |
Contributor
There was a problem hiding this comment.
Я перенёс и отрефакторил этот файл, пожалуйста, отребейзься на свежий мастер
nickolaym
reviewed
Oct 14, 2023
| { | ||
| "name": "just_simple_test", | ||
| "setup": "", | ||
| "run": "CI=1 cmake . && make just_simple_test", |
Contributor
There was a problem hiding this comment.
Лучше, наверно, не через окружение (мало ли, будет конфликтовать), а через дефайны комстроки?
cmake . -Ddisable_gtest=1 && .....
nickolaym
reviewed
Oct 14, 2023
| { | ||
| "tests": [ | ||
| { | ||
| "name": "just_simple_test", |
Contributor
There was a problem hiding this comment.
Я сделал семейство заведомо позитивных и заведомо негативных тестовых файлов.
Нужно как-то учесть это в скрипте CI.
nickolaym
reviewed
Oct 14, 2023
| #### Arguments | ||
|
|
||
| ``` | ||
| ```c++ |
nickolaym
reviewed
Oct 14, 2023
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wextra-semi -O1 -g -fsanitize=address -fno-omit-frame-pointer") | ||
| endif() | ||
|
|
||
| if(DEFINED ENV{CI}) |
Contributor
There was a problem hiding this comment.
Лучше не через ENV управлять, наверное.
А также можно попробовать сделать локальную сборку GTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавляю прогон тестов в окружении CI, который используется в домашках и дорешках
Сейчас в них производится только компиляция, без запуска. Надо дочинить и включить запуск и понапихать какие-то более адекватные проверки