fix: circular dependency when publishing cot and cot-core#514
Merged
Conversation
seqre
approved these changes
Mar 18, 2026
|
Bencher Report| Branch | fix-cot-core-publish-no-verify |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,532.10 µs(+9.44%)Baseline: 5,968.59 µs | 7,140.28 µs (91.48%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,083.40 µs(+4.98%)Baseline: 1,032.03 µs | 1,189.09 µs (91.11%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 999.72 µs(+5.15%)Baseline: 950.72 µs | 1,087.74 µs (91.91%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 968.83 µs(+6.19%)Baseline: 912.35 µs | 1,047.98 µs (92.45%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 16,863.00 µs(-3.93%)Baseline: 17,553.00 µs | 20,900.89 µs (80.68%) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates cot-core’s dev-dependency on cot to avoid a circular dependency issue during publishing/release tooling while still supporting local development/test features.
Changes:
- Switch
cot-core’sdev-dependencies.cotfrom a workspace dependency to an explicit path dependency. - Add an inline comment documenting the publishing-cycle motivation for the change.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.