Skip to content

Conversation

@stefanvanburen
Copy link
Member

Experimenting with if we need these.

Experimenting with if we need these.

Signed-off-by: Stefan VanBuren <svanburen@buf.build>
This should all be through `uv` now.

Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Copy link
Collaborator

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanvanburen - I think they're technically not needed but then python becomes whatever happens to be on the github runner at the time, which can be different as the runner image gets updated even within the same label.

For a simple source-only wheel, it may be a bit pedantic but I tend to like having explicit setup- actions for all dependencies to still ensure tracking of versions used.

As an aside, I just noticed that GitHub's attestations don't display anything about the runner

https://github.com/connectrpc/connect-python/attestations/17478928

Not sure if it's a display or recording issue, but it seems the workflow is easier to verify for these too.

@stefanvanburen
Copy link
Member Author

Thanks @stefanvanburen - I think they're technically not needed but then python becomes whatever happens to be on the github runner at the time, which can be different as the runner image gets updated even within the same label.

For a simple source-only wheel, it may be a bit pedantic but I tend to like having explicit setup- actions for all dependencies to still ensure tracking of versions used.

Doesn't the python version just end up getting determined by uv though? (I guess it ought to just match since I'd expect it to effectively use the same resolution of using the pyproject.toml.)

I hadn't thought about the attestations bit; I don't mind leaving these as-is if they end up being useful in that output down the road.

@anuraaga
Copy link
Collaborator

Ah you're right - I had the impression setup-python picks the minimum supported version like setup-go does, but it seems to not be true. I agree then that uv will have the same behavior, and in practice we are always getting 3.14 here implicitly.

Now that we're using renovate, if we hardcoded a value like 3.14 it would automatically get updated, giving a more static view, but don't feel bad about just going with the current state then.

@stefanvanburen stefanvanburen marked this pull request as ready for review February 10, 2026 13:29
@stefanvanburen stefanvanburen merged commit 6bb0f5a into main Feb 10, 2026
23 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/drop-setup-python branch February 10, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants