Open
Conversation
Co-authored-by: Gonzalo Casas <gonzalocasas@gmail.com>
chenkasirer
approved these changes
Feb 17, 2026
Member
chenkasirer
left a comment
There was a problem hiding this comment.
mostly LGTM, added a couple of small suggestions and generally speaking the added methods and properties need to also be added to the interface module i.e. compas.geometry.Brep
|
|
||
| from compas.geometry import BrepTrim | ||
| from compas_rhino.geometry import RhinoNurbsCurve | ||
| from compas_rhino.geometry.brep.edge import RhinoBrepEdge |
Member
There was a problem hiding this comment.
can this be imported instead form 2nd level?
Author
There was a problem hiding this comment.
I tried but it gives me a circular error import
Co-authored-by: Chen Kasirer <chen902@gmail.com>
Co-authored-by: Chen Kasirer <chen902@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some methods and attribute to RhinoBreps and RhinoCurve. This methods will be used in the class Coding Architecture II
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.