Merged
Conversation
Our modals have extremely high z-index, so any <body>-parented element is rendered "under" them
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oaphi
force-pushed
the
0valt/2032/category-select-fix
branch
from
ac1a171 to
f0aa6f2
Compare
Member
Author
|
Let's make another small deploy on merge (no need to wait for me to do the latter either if everything looks good) |
cellio
approved these changes
Mar 25, 2026
Member
cellio
left a comment
cellio
left a comment
There was a problem hiding this comment.
Tested and LGTM. Code looks fine with my usual caveat about JS.
ArtOfCode-
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2032
The PR also actually enables category search by name (that it doesn't work is, ironically, only noticeable when trying to narrow down a category change dropdown's options):