fix: prevent scrollbars in inline toolbar on Safari#2990
Open
pierreeurope wants to merge 1 commit intocodex-team:nextfrom
Open
fix: prevent scrollbars in inline toolbar on Safari#2990pierreeurope wants to merge 1 commit intocodex-team:nextfrom
pierreeurope wants to merge 1 commit intocodex-team:nextfrom
Conversation
The inline popover items container inherits overflow-y: auto from popover.css. In Safari, this causes scrollbars to appear in the inline toolbar when selecting text, partially covering toolbar items. Adding overflow: hidden to the ce-popover__items selector inside ce-popover--inline prevents the browser from rendering scroll controls since the flex layout handles all item positioning.
pierreeurope
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2988
The inline toolbar shows scrollbars in Safari because
.ce-popover__itemsinheritsoverflow-y: autofrompopover.css. Safari renders the scroll control even when the content fits in the container, partially covering toolbar items.Adding
overflow: hiddento the.ce-popover__itemsselector inside.ce-popover--inlineprevents this. The flex layout already handles all item placement so scrolling isn't needed here.One line change to
src/styles/popover-inline.css.